proxmox/pve-guest-common
1
0
Fork 0
mirror of https://git.proxmox.com/git/pve-guest-common.git synced 2026-07-11 17:12:41 +00:00
Code Issues Projects Releases Packages Wiki Activity
No description
396 commits 3 branches 0 tags 528 KiB
Find a file
Exact
Daniel Kral e10fabc1f2 tunnel: treat reader_stderr as optional parameter in read_tunnel 
The reader_stderr parameter was introduced for a specific use case for
the users of fork_ssh_tunnel(). The other callers, such as
fork_websocket_tunnel(), do not provide the parameter and the Perl
interpreter will warn about this:

    Use of uninitialized value $reader_stderr in <HANDLE> at /usr/share/perl5/PVE/Tunnel.pm line 77.
    readline() on unopened filehandle at /usr/share/perl5/PVE/Tunnel.pm line 77.

Therefore, treat reader_stderr as an optional parameter by not reading
from the handle if it is not provided.

Fixes: 8c8aa63 ("tunnel: redirect stderr to log function")
Signed-off-by: Daniel Kral <d.kral@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Link: https://lore.proxmox.com/20260630084332.32566-1-d.kral@proxmox.com
[FE: add comment mentioning reader_stderr is only used by SSH tunnel]
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2026-07-03 15:34:19 +02:00
debian bump version to 6.0.4 2026-06-17 10:17:26 +02:00
src tunnel: treat reader_stderr as optional parameter in read_tunnel 2026-07-03 15:34:19 +02:00
Makefile buildsys: add top-level make tidy target 2025-06-16 15:21:47 +02:00