No description
Find a file
Arthur Bied-Charreton 1c4cbdc141 fix #7242: client: warn on logout if no ticket is found
When running `proxmox-backup-client logout` on a repository that has no
stored credentials, emit a warning instead of silently succeeding.

This can help users identify typos without breaking scripts that may run
logout as a precautionary first step.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>
Link: https://lore.proxmox.com/20260120160136.164952-2-a.bied-charreton@proxmox.com
2026-01-22 16:43:21 +01:00
.cargo cargo config: add debug=true 2024-06-25 14:21:58 +02:00
debian add basic multiarch support to resulting package and executable locations 2026-01-21 22:22:17 +01:00
docs d/changelog: fix typos in historic entries 2025-11-25 15:47:36 +01:00
etc etc: provide and enable mount unit for /run/proxmox-backup 2025-11-24 15:13:05 +01:00
examples clippy: inline variables into format strings 2025-10-30 13:31:24 +01:00
pbs-buildcfg add basic multiarch support to resulting package and executable locations 2026-01-21 22:22:17 +01:00
pbs-client fix #7242: client: warn on logout if no ticket is found 2026-01-22 16:43:21 +01:00
pbs-config config: enable config version cache for datastore 2026-01-14 10:52:29 +01:00
pbs-datastore chunk store: move bad chunk filename generation into dedicated helper 2026-01-14 14:42:37 +01:00
pbs-fuse-loop clippy: inline variables into format strings 2025-10-30 13:31:24 +01:00
pbs-key-config clippy: inline variables into format strings 2025-10-30 13:31:24 +01:00
pbs-pxar-fuse tree-wide: make hidden lifetimes explicit 2025-11-04 16:40:48 +01:00
pbs-tape tape: fix encryption on certain tape drives 2025-12-16 09:09:15 +01:00
pbs-tools tree-wide: make hidden lifetimes explicit 2025-11-04 16:40:48 +01:00
proxmox-backup-banner tree wide: fix formatting style via cargo fmt 2025-10-31 11:06:21 +01:00
proxmox-backup-client fix #7219: client: mount: align encryption key loading behavior 2026-01-13 14:53:32 +01:00
proxmox-file-restore tree wide: fix formatting style via cargo fmt 2025-10-31 11:06:21 +01:00
proxmox-restore-daemon clippy: inline variables into format strings 2025-10-30 13:31:24 +01:00
pxar-bin tree wide: fix formatting style via cargo fmt 2025-10-31 11:06:21 +01:00
src add basic multiarch support to resulting package and executable locations 2026-01-21 22:22:17 +01:00
templates notifications/pbsXtoX: adapt to proxmox-apt making old_version optional 2025-11-14 09:47:54 +01:00
tests clippy: inline variables into format strings 2025-10-30 13:31:24 +01:00
www fix #7149: ui: prohibit realm update on login 2026-01-13 11:26:15 +01:00
zsh-completions zsh: fix completions 2021-09-03 10:29:48 +02:00
.gitignore gitignore: generally ignore generated systemd service files 2024-03-08 08:00:30 +01:00
Cargo.toml update proxmox-s3-client to 1.2.5 2026-01-16 09:12:20 +01:00
defines.mk docs: add datastore.cfg.5 man page 2021-02-10 11:05:02 +01:00
Makefile make: add architecture to upload target 2026-01-21 22:39:33 +01:00
README.rst readme: fix typo 2025-11-25 15:47:36 +01:00
rustfmt.toml bump edition in rustfmt.toml 2022-10-13 15:01:11 +02:00
TODO.rst tape: add/use rust scsi changer implementation using libsgutil2 2021-01-25 13:14:07 +01:00

Build & Release Notes
*********************

``rustup`` Toolchain
====================

We normally want to build with the ``rustc`` Debian package (see below). If you
still want to use ``rustup`` for other reasons (e.g. to easily switch between
the official stable, beta, and nightly compilers), you should set the following
``rustup`` configuration to use the Debian-provided ``rustc`` compiler
by default:

    # rustup toolchain link system /usr
    # rustup default system


Versioning of proxmox helper crates
===================================

To use current git master code of the proxmox* helper crates, add::

   git = "git://git.proxmox.com/git/proxmox"

or::

   path = "../proxmox/proxmox"

to the proxmox dependency, and update the version to reflect the current,
pre-release version number (e.g., "0.1.1-dev.1" instead of "0.1.0").


Local cargo config
==================

This repository ships with a ``.cargo/config.toml`` that replaces the crates.io
registry with packaged crates located in ``/usr/share/cargo/registry``.

A similar config is also applied building with dh_cargo. Cargo.lock needs to be
deleted when switching between packaged crates and crates.io, since the
checksums are not compatible.

To reference new dependencies (or updated versions) that are not yet packaged,
the dependency needs to point directly to a path or git source (e.g., see
example for proxmox crate above).


Build
=====
on Debian 12 Bookworm

Setup:
  1. # echo 'deb http://download.proxmox.com/debian/devel/ bookworm main' | sudo tee /etc/apt/sources.list.d/proxmox-devel.list
  2. # sudo wget https://enterprise.proxmox.com/debian/proxmox-release-bookworm.gpg -O /etc/apt/trusted.gpg.d/proxmox-release-bookworm.gpg
  3. # sudo apt update
  4. # sudo apt install devscripts debcargo clang
  5. # git clone git://git.proxmox.com/git/proxmox-backup.git
  6. # cd proxmox-backup; sudo mk-build-deps -ir

Note: 2. may be skipped if you already added the PVE or PBS package repository

You are now able to build using the Makefile or cargo itself, e.g.::

  # make deb
  # # or for a non-package build
  # cargo build --all --release

Design Notes
************

Here are some random thought about the software design (unless I find a better place).


Large chunk sizes
=================

It is important to notice that large chunk sizes are crucial for performance.
We have a multi-user system, where different people can do different operations
on a datastore at the same time, and most operation involves reading a series
of chunks.

So what is the maximal theoretical speed we can get when reading a series of
chunks? Reading a chunk sequence need the following steps:

- seek to the first chunk's start location
- read the chunk data
- seek to the next chunk's start location
- read the chunk data
- ...

Lets use the following disk performance metrics:

:AST: Average Seek Time (second)
:MRS: Maximum sequential Read Speed (bytes/second)
:ACS: Average Chunk Size (bytes)

The maximum performance you can get is::

  MAX(ACS) = ACS /(AST + ACS/MRS)

Please note that chunk data is likely to be sequential arranged on disk, but
this it is sort of a best case assumption.

For a typical rotational disk, we assume the following values::

  AST: 10ms
  MRS: 170MB/s

  MAX(4MB)  = 115.37 MB/s
  MAX(1MB)  =  61.85 MB/s;
  MAX(64KB) =   6.02 MB/s;
  MAX(4KB)  =   0.39 MB/s;
  MAX(1KB)  =   0.10 MB/s;

Modern SSD are much faster, lets assume the following::

  max IOPS: 20000 => AST = 0.00005
  MRS: 500Mb/s

  MAX(4MB)  = 474 MB/s
  MAX(1MB)  = 465 MB/s;
  MAX(64KB) = 354 MB/s;
  MAX(4KB)  =  67 MB/s;
  MAX(1KB)  =  18 MB/s;


Also, the average chunk directly relates to the number of chunks produced by
a backup::

  CHUNK_COUNT = BACKUP_SIZE / ACS

Here are some staticics from my developer workstation::

  Disk Usage:       65 GB
  Directories:   58971
  Files:        726314
  Files < 64KB: 617541

As you see, there are really many small files. If we would do file
level deduplication, i.e. generate one chunk per file, we end up with
more than 700000 chunks.

Instead, our current algorithm only produce large chunks with an
average chunks size of 4MB. With above data, this produce about 15000
chunks (factor 50 less chunks).